wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
741 stars 719 forks source link

Remove unnecessary PBKDF2 info logs from the startup #20708

Closed darshanasbg closed 1 month ago

darshanasbg commented 1 month ago

Is your suggestion related to an experience ? Please describe.

We have following INFO log in the product startup.

[2024-07-17 11:34:17,286] []  INFO {org.wso2.carbon.identity.hash.provider.pbkdf2.internal.PBKDF2HashServiceComponent} - PBKDF2 bundle activated successfully.

From the overall product startup context, this is not a necessary detail to appear in the product startup.

Further this go against our general practice where the the product have more than 500 OSGi bundles and it only logs any errors during the its bundle activation.

Describe the improvement Remove the INFO log and improve the error handling in the bundle activation.

https://github.com/wso2-extensions/identity-hash-provider-pbkdf2/blob/main/components/org.wso2.carbon.identity.hash.provider.pbkdf2/src/main/java/org/wso2/carbon/identity/hash/provider/pbkdf2/internal/PBKDF2HashServiceComponent.java#L47

Additional context Refer: https://github.com/wso2-extensions/identity-inbound-auth-saml/blob/master/components/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/internal/IdentitySAMLSSOServiceComponent.java#L229

darshanasbg commented 1 month ago

CC: @Osara-B

Osara-B commented 1 month ago

Fixed with,