wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
748 stars 729 forks source link

DELETE FROM IDN_OIDC_REQ_OBJECT_REFERENCE ... queries #21598

Open DimuthuKasunWP opened 3 weeks ago

DimuthuKasunWP commented 3 weeks ago

These queries are executed during token revocation[1][2]. However, it seems they are unnecessary, as the entries will be cleaned up through internal or external cleanup tasks via foreign constraints.

DELETE FROM IDN_OIDC_REQ_OBJECT_REFERENCE WHERE TOKEN_ID = ?; DELETE FROM IDN_OIDC_REQ_OBJECT_REFERENCE WHERE CODE_ID = ?;

[1]https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/openidconnect/handlers/RequestObjectHandler.java#L77 [2]https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/openidconnect/handlers/RequestObjectHandler.java#L81

nilasini commented 2 days ago

@sadilchamishka can we close this