Verify Migration Preparedness for GraalJS as default scripting engine to execute Adaptive Scripts

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.

http://wso2.github.io/

Apache License 2.0

748 stars 729 forks source link

Verify Migration Preparedness for GraalJS as default scripting engine to execute Adaptive Scripts #21612

Closed aaujayasena closed 9 hours ago

aaujayasena commented 3 weeks ago

Describe the issue: From 7.1.0 uses GraalJS as the default engine for adaptive authentication scripts, replacing Nashorn [1]. This change could potentially impact customers who have developed their own adaptive functions [2]. Therefore, It would be essential to develop a migration plan and prioritize.

[1] https://github.com/wso2/product-is/issues/21182 [2] https://is.docs.wso2.com/en/next/references/extend/authentication/conditional-auth/write-custom-functions-for-conditional-authentication/

Key Considerations:

Identify Affected Customers:Identify any customers who have implemented custom adaptive functions and are planning to migrate to IS 7.1.0.
Migration Plan: Identify necessary changes for adaptive authentication scripts, create a detailed migration plan, and ensure resources are available to support script updates.
Engine Switching Options: Since WSO2 Identity Server now supports three JavaScript engines—Nashorn, OpenJDK Nashorn, and GraalJS—develop and share comprehensive guidance on how to switch between these engines, including clear configuration steps.

shanggeeth commented 3 weeks ago

Required Migration Steps:

In case customers have implemented their own custom adaptive functions,

They have to add the @HostAccess.Export imported from org.graalvm.polyglot.HostAccess package to the method of the class that is implementing @FunctionalInterface
Alternatively they can use other script engines without the need for this code level change.
```
[AdaptiveAuth]
ScriptEngine = "openjdkNashorn"
```
```
[AdaptiveAuth]
ScriptEngine = "nashorn"
```

nilasini commented 3 weeks ago

@shanggeeth Did we create a migration doc issue? If not shall we create it?

shanggeeth commented 3 weeks ago

@shanggeeth Did we create a migration doc issue? If not shall we create it?

Migration Doc Issue: https://github.com/wso2/product-is/issues/20613

nilasini commented 9 hours ago

closing since we are tracking with https://github.com/wso2/product-is/issues/20613