wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
744 stars 723 forks source link

ID token missing in OIDC requests when request parameter included with multiple scopes #2959

Closed darshanasbg closed 6 years ago

darshanasbg commented 6 years ago

Following request does not works

https://localhost:9443/oauth2/authorize?scope=openid&response_type=code id_token&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fplayground2%2Foauth2client&client_id=Flaob9wq5qNNYyIPgfI3RNqwAqAa&request=eyJhbGciOiJSUzI1NiIsImtpZCI6IjM1OTBhYTkxZWYwYWQ3MDM4NTM4MGMzYjgwZDM4MTc0N2IxZWNlNTc4NjVkZDA1NzJjMmQyZmFmNGMzYmUzZGQiLCJ0eXAiOiJKV1QifQ.eyJhdWQiOiJodHRwczovL2xvY2FsaG9zdDo5NDQzL29hdXRoMi90b2tlbiIsImlzcyI6IkZsYW9iOXdxNXFOTll5SVBnZkkzUk5xd0FxQWEiLCJyZXNwb25zZV90eXBlIjoiY29kZSBpZF90b2tlbiIsImNsaWVudF9pZCI6IkZsYW9iOXdxNXFOTll5SVBnZkkzUk5xd0FxQWEiLCJyZWRpcmVjdF91cmkiOiJodHRwczovL3dzbzIuY29tIiwic2NvcGUiOiJvcGVuaWQgdGVzdCIsInN0YXRlIjoiWVdsemNEb3pNVFEyMSIsIm5vbmNlIjoibi0wUzZfV3pBMk1qIiwibWF4X2FnZSI6ODY0MDAsImNsYWltcyI6eyJ1c2VyaW5mbyI6eyJuaWNrbmFtZSI6eyJ2YWx1ZSI6IjM3N2ExZTQyLTg1MzktNDNiMS05YzBmLTg2YTQxNTExYzcxYyIsImVzc2VudGlhbCI6dHJ1ZX19LCJpZF90b2tlbiI6eyJuaWNrbmFtZSI6eyJ2YWx1ZSI6IjM3N2ExZTQyLTg1MzktNDNiMS05YzBmLTg2YTQxNTExYzcxYyIsImVzc2VudGlhbCI6dHJ1ZX0sImFjciI6eyJlc3NlbnRpYWwiOnRydWUsInZhbHVlcyI6WyJ1cm46b3BlbmJhbmtpbmc6cHNkMjpzY2EiLCJ1cm46b3BlbmJhbmtpbmc6cHNkMjpjYSJdfX19fQ.nWwix-1SrqTpiZBRIi3aSKEhRZYm-Czk8lqn5yoUcAWmsw-yjX3ZRs3KdKAJExInfblp26LGfoUnRTRR_bNfDX0oQ4Nm7y3ErFjafSGC9RseUJHcIOdsDdxLl0-TgQTi8M_d7Rgzp_kXZuWdxYkP3I9EqtBrLOwPW48NmK-Nry3T_Lg1LXx1H49ij34hMZuW2uS2DdfOfLuLleQIJkxS6j4hiBjojKkEde-Ja4aVujVhBb2zFjNuPND6kxX0xH_kbaukBHoVbYFhAE0KSayvbv2BQcSk6OGIvqWmxQHxNd-ocy9EPQBJ5B8cDycEvL6qFO_vZtkIvsVbgY2hCs8KZA

Here the decoded request object looks like following, { "aud": "https://localhost:9443/oauth2/token", "iss": "Flaob9wq5qNNYyIPgfI3RNqwAqAa", "response_type": "code id_token", "client_id": "Flaob9wq5qNNYyIPgfI3RNqwAqAa", "redirect_uri": "https://wso2.com", "scope": "openid test", "state": "YWlzcDozMTQ21", "nonce": "n-0S6_WzA2Mj", "max_age": 86400, "claims": { "userinfo": { "nickname": { "value": "377a1e42-8539-43b1-9c0f-86a41511c71c", "essential": true } }, "id_token": { "nickname": { "value": "377a1e42-8539-43b1-9c0f-86a41511c71c", "essential": true }, "acr": { "essential": true, "values": [ "urn:openbanking:psd2:sca", "urn:openbanking:psd2:ca" ] } } } }

But following request works correct and returning id_token as expected since it have only one scope, https://localhost:9443/oauth2/authorize?scope=openid&response_type=code id_token&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fplayground2%2Foauth2client&client_id=Flaob9wq5qNNYyIPgfI3RNqwAqAa&request=eyJhbGciOiJSUzI1NiIsImtpZCI6IjM1OTBhYTkxZWYwYWQ3MDM4NTM4MGMzYjgwZDM4MTc0N2IxZWNlNTc4NjVkZDA1NzJjMmQyZmFmNGMzYmUzZGQiLCJ0eXAiOiJKV1QifQ.eyJhdWQiOiJodHRwczovL2xvY2FsaG9zdDo5NDQzL29hdXRoMi90b2tlbiIsImlzcyI6IkZsYW9iOXdxNXFOTll5SVBnZkkzUk5xd0FxQWEiLCJyZXNwb25zZV90eXBlIjoiY29kZSBpZF90b2tlbiIsImNsaWVudF9pZCI6IkZsYW9iOXdxNXFOTll5SVBnZkkzUk5xd0FxQWEiLCJyZWRpcmVjdF91cmkiOiJodHRwczovL3dzbzIuY29tIiwic2NvcGUiOiJvcGVuaWQiLCJzdGF0ZSI6IllXbHpjRG96TVRRMjEiLCJub25jZSI6Im4tMFM2X1d6QTJNaiIsIm1heF9hZ2UiOjg2NDAwLCJjbGFpbXMiOnsidXNlcmluZm8iOnsibmlja25hbWUiOnsidmFsdWUiOiIzNzdhMWU0Mi04NTM5LTQzYjEtOWMwZi04NmE0MTUxMWM3MWMiLCJlc3NlbnRpYWwiOnRydWV9fSwiaWRfdG9rZW4iOnsibmlja25hbWUiOnsidmFsdWUiOiIzNzdhMWU0Mi04NTM5LTQzYjEtOWMwZi04NmE0MTUxMWM3MWMiLCJlc3NlbnRpYWwiOnRydWV9LCJhY3IiOnsiZXNzZW50aWFsIjp0cnVlLCJ2YWx1ZXMiOlsidXJuOm9wZW5iYW5raW5nOnBzZDI6c2NhIiwidXJuOm9wZW5iYW5raW5nOnBzZDI6Y2EiXX19fX0.FWmu2xHzphy1y_euV8sDD25WSpFXxoNHSStpib1IBcHkSeLe7smlDZ19YUUp54HBn-DwAPtnu-A0LIuAVZMsQxMny667iSkgtkN5oZAjBSczIpZRk5mlS3c2Hak_PqtzyVoTixj5DtILbvRitoVk8lkw1H5ewrYRP9d4TxDTF7rV1ARFPcnj5ATpvqN0CQiNIxJtnA3afy_QyU4PqyHRq2uPT4OBzq6KInGkpFL01IaTiR9r6a7DLkzQo5-8oR6jV8eL2KxK8k6eJveiB--08-fcNWbOivCr8M9vULHayms0eb_EcGri4mGZBdOtiEZCyj-J0m6m8uA-DL2_1PtQUw

darshanasbg commented 6 years ago

Fixed with https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/862