Improving the claim mapping in IDP and SP configurations

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.

http://wso2.github.io/

Apache License 2.0

741 stars 720 forks source link

Improving the claim mapping in IDP and SP configurations #5437

Open ashensw opened 5 years ago

ashensw commented 5 years ago

Currently we have only support the standard OIDC dialect for the OIDC IDPs and SPs. So we have to do the following improvements in the product,

Provide the flexibility to select a claim dialect per IDP and SP regardless of the protocols (OIDC, SAML etc).
Provide the flexibility to add a custom claim mapping per IDP and SP for OIDC protocols as well.

janakamarasena commented 5 years ago

The above PR makes improvements based on this issue. It introduces a global configuration to allow federated authenticators to use the idp local claim dialect instead of the authenticator's claim dialect when using a custom dialect claim mapping.

mefarazath commented 4 years ago

@janakamarasena Why is this issue still open? are there any pending improvements?

mefarazath commented 4 years ago

Also, why can't we have our default behaviour to allow custom claim mappings if they are defined at the IDP level?

janakamarasena commented 4 years ago

@mefarazath we have only done the improvement related to IDP claim mapping ATM. +1 to change the default behaviour.