UUID generator and SMS OTP generator needs to be extended. - Githubissues

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.

http://wso2.github.io/

Apache License 2.0

748 stars 727 forks source link

UUID generator and SMS OTP generator needs to be extended. #6446

Closed somindatommy closed 15 hours ago

somindatommy commented 5 years ago

Related To Issue: https://github.com/wso2/product-is/issues/6339 Related To PR: https://github.com/wso2-support/identity-governance/pull/107

In the latest user self registration implementation, user secret key for account confirmation is generated by the function generateSecretKey - [1]. The method generates a secret key for email verification using the UUID generator in [2] and an SMS OTP for mobile verification in [3]. These secret generators does not provide any extensions.
Therefore, these secret generators needs to be provide as a separate service since they can be used in multiple occasions.

[1] - https://github.com/wso2-support/identity-governance/blob/f08fb62159f94921f0da0a4aea7844f372bb54c9/components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/handler/UserSelfRegistrationHandler.java#L476

[2] - https://github.com/wso2-support/identity-governance/blob/f08fb62159f94921f0da0a4aea7844f372bb54c9/components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/handler/UserSelfRegistrationHandler.java#L487

[3] -https://github.com/wso2-support/identity-governance/blob/f08fb62159f94921f0da0a4aea7844f372bb54c9/components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/handler/UserSelfRegistrationHandler.java#L458

isharak commented 15 hours ago

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!