wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
727 stars 712 forks source link

Should accessURL be a mandatory attribute in the SP config? #7095

Open darshanasbg opened 4 years ago

darshanasbg commented 4 years ago

Right now accessURL is mandatory if only the Service Provider is discoverable.

accessURL is required to avoid other issues like,

Thus, IMO accessURL should be a mandatory attribute in Service Provider.

Along with that, for better UX, it can make imageURL also mandatory. So all related UIs can use SP logo in consistent way without depending whether application is discoverable or not.

thanujalk commented 4 years ago

+1. Better make this mandatory.

omindu commented 4 years ago

@darshanasbg What's exactly meant by discoverable in this context?

Also, IMO keeping the imageURL should be kept optional and not a mandatory step in creating the SP.

mefarazath commented 4 years ago

It makes sense to make the accessURL mandatory.

But it doesn't sound right to mandate the imageURL.

So all related UIs can use SP logo in consistent way without depending whether application is discoverable or not.

Can't we have a generic image if the application doesn't specify an imageURL? That way all apps will have an image.

darshanasbg commented 4 years ago

It makes sense to make the accessURL mandatory.

But it doesn't sound right to mandate the imageURL.

So all related UIs can use SP logo in consistent way without depending whether application is discoverable or not.

Can't we have a generic image if the application doesn't specify an imageURL? That way all apps will have an image.

As of now, we can't have a default application image when we register the SP in management console.. We will have it in the Admin portal.

But we do we show a default application image (if 'imageURL' is not present), in the places we need to show an SP image (like, user-portal)..