Issues/improvements with federated authenticator metadata response

tharindu-b-hewage commented 4 years ago

Describe the Issue:

Even though federated authenticator metadata response supports isConfidential parameter, it is not properly configured for the OpenIDConnectAuthenticator's Client Secret paremeter(shows false, instead of true). This needs to be checked in all available federated authenticator properties.
The same response does not have a meta property to indicate for a URL field. This would be useful to enforce URL validation from the UI.

How To Reproduce:

Invoke https://localhost:9443/t/{{tenant-domain}}/api/server/v1/identity-providers/meta/federated-authenticators, and get the list of authenticators.
Fetch OpenIDConnectAuthenticator metadata with https://localhost:9443/t/carbon.super/api/server/v1/identity-providers/meta/federated-authenticators/{authenticator-id}I.
Observe followings. 3.1 isConfidential is false 3.2 URL fields are considered as text.

Expected behavior:

isConfidential should be true for appropriate fields(ex: Client Id in the aforementioned scenario).
URL fields should have a property to indicate them as URLs.

Device Information (Please complete the following information) :

emswbandara commented 4 years ago

@tharindu-bandara can you please create another issue to track the URL option. It is an improvement which requires changes to the Property model.

tharindu-b-hewage commented 4 years ago

@tharindu-bandara can you please create another issue to track the URL option. It is an improvement that requires changes to the Property model.

tharindu-b-hewage commented 4 years ago

@emswbandara

Kindly find the meta-properties below, which need to be marked as confidential.

client secret field in Oauth2, Facebook, Microsoft, Google, Yahoo, Office 365 Federated Authenticators
api secret field in Twitter Federated Authenticator
service principal password field in the Kerberos Federated Authenticator

emswbandara commented 4 years ago

@tharindu-bandara

wso2 / product-is