wso2 / product-microgateway

Choreo Connect is a cloud-native, open-source, and developer-centric API gateway.
https://wso2.com/choreo/choreo-connect/
Apache License 2.0
287 stars 246 forks source link

Bug fix: deadlocked worker pool threads during a controlplane connection failure. #3487

Closed VirajSalaka closed 5 months ago

VirajSalaka commented 5 months ago

Purpose

Bug Fix: When the retry limit reaches its maximum limit, the worker threads which calls the control plane gets blocked.

Issues

Fixes #

Automation tests

Tested environments

Locally tested in the following manner. Started choreo-product-apim locally then Started choreo-connect locally pointing to local choreo-product-apim and ASB connection string. (I used PDP mode in choreo-connect here) Stopped the choreo-product-apim so that we could replicate a network unreachable type failure. Sent deploy events via ASB

Monitored the behavior with and without the fix. And with the fix it did not blocked.


Maintainers: Check before merge

choreo-cicd commented 5 months ago

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240129.9

choreo-cicd commented 5 months ago

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240129.9

choreo-cicd commented 5 months ago

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240129.9

choreo-cicd commented 5 months ago

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240201.1

choreo-cicd commented 5 months ago

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240201.1

choreo-cicd commented 5 months ago

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240201.1

choreo-cicd commented 5 months ago

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240201.3

choreo-cicd commented 5 months ago

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240201.3

choreo-cicd commented 5 months ago

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240201.3