[Choreo] [Bugfix] Adds keepalive pings to enforcer XDS connection - Githubissues

wso2 / product-microgateway

Choreo Connect is a cloud-native, open-source, and developer-centric API gateway.

https://wso2.com/choreo/choreo-connect/

Apache License 2.0

287 stars 246 forks source link

[Choreo] [Bugfix] Adds keepalive pings to enforcer XDS connection #3541

Closed jhivandb closed 1 week ago

jhivandb commented 1 week ago

Purpose

This PR aims to resolve an issue with the XDS/GRPC connection where the enforcer doesn't know that the connection has failed and doesn't reach out to another replica of the local adapter for new configuration.

This fix works by configuring GRPC client on the enforcer to send HTTP/2 Ping frames every 2 minutes, if the ping isn't returned with an ACK the connection is closed. This only checks connection health and not the healthiness of the adapter.

Issues

Automation tests

Unit tests added: No
Integration tests added: No

Tested environments

This was tested with in a localsetup where the adapter is paused using a debugger after initial discovery and subscription from the enforcer.

Before this fix the connection to the adapter would remain until the enforcer checks the connection in 2 hours (default keep alive configuration).
After this fix. The enforcer checks the connection after 2 minutes and disconnects, when the adapter is restarted, the enforcer reconnects to it successfully.

Maintainers: Check before merge

[ ] Assigned 'Type' label
[ ] Assigned the project
[ ] Validated respective github issues
[ ] Assigned milestone to the github issue(s)

choreo-cicd commented 1 week ago

[] Controlplane cluster : dev-deployment-v2 : 20240627.10

choreo-cicd commented 1 week ago

[] : dev-deployment-v2 : 20240627.10

choreo-cicd commented 1 week ago

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240627.10

choreo-cicd commented 1 week ago

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240627.10

choreo-cicd commented 1 week ago

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240628.1

choreo-cicd commented 1 week ago

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240628.1

choreo-cicd commented 1 week ago

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240628.1

choreo-cicd commented 1 week ago

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240628.1

choreo-cicd commented 1 week ago

[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240628.4

choreo-cicd commented 1 week ago

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240628.4

choreo-cicd commented 1 week ago

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240628.4

choreo-cicd commented 1 week ago

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240628.4