search

wso2 / puppet-apim

41 stars 42 forks source link

WSO2_CARBON_DB configuration hardcoded #80

Closed ricksbrown closed 5 years ago

ricksbrown commented 5 years ago

Description: The template master-datasources.xml.erb includes hard-coded database configuration for the WSO2_CARBON_DB.

This obviosuly makes it impossible for anyone to reconfigure the database without hacking files under source control.

Suggested Labels:

Suggested Assignees:

Affected Product Version:

OS, DB, other environment details and versions:

Steps to reproduce:

Related Issues:

ricksbrown commented 5 years ago

Note that other parameters are hard-coded for all the other databases too For example:

<validationQuery>SELECT 1</validationQuery>

When connecting to Oracle DB this is apparently meant to read:

<validationQuery>SELECT 1 FROM DUAL</validationQuery>

This is just an example, the same seems to be true for other params such as

<defaultAutoCommit>true</defaultAutoCommit>

How are we supposed to change these via puppet / hiera if they are hard-coded in the template?