search

wso2 / reference-implementation-consumerdatastandards-au

Reference Toolkit Implementation for Consumer Data Standards Open Banking Specification
Apache License 2.0
2 stars 6 forks source link

Data Clusters are not shown according to the spec for the scopes #29

Closed Akila94 closed 2 weeks ago

Akila94 commented 2 weeks ago

Description: According to the specification [1], when there are both detailed and basic data clusters for a provided scope, the data clusters should be merged. This is implemented in OB2 but this is not displayed properly in CDS toolkit. This needs to be fixed.

Also, in the consent amendment and non-amendment scenarios, the method [2] uses the method [3] to get the data clusters from scopes. But in the above two scenarios, the JSONArray of scopes which is an argument of the method [3] is utilized differently.

This inconsistency leads to issues when the original fix of this issue is done. Hence this inconsistency is also needed to be addressed and needed to be fixed.

[1] https://consumerdatastandardsaustralia.github.io/standards/#data-language-standards-common

[2] https://github.com/wso2/reference-implementation-consumerdatastandards-au/blob/47641cdb89f997e6ac1049cc756a9acbc8baaae8/components/org.wso2.openbanking.cds.consent.extensions/src/main/java/org/wso2/openbanking/cds/consent/extensions/authorize/impl/retrieval/CDSDataClusterRetrievalStep.java#L47

[3] https://github.com/wso2/reference-implementation-consumerdatastandards-au/blob/47641cdb89f997e6ac1049cc756a9acbc8baaae8/components/org.wso2.openbanking.cds.consent.extensions/src/main/java/org/wso2/openbanking/cds/consent/extensions/authorize/impl/retrieval/CDSDataClusterRetrievalStep.java#L131

Suggested Labels: CDS toolkit, Bug

Suggested Assignees:

Affected Product Version:

OS, DB, other environment details and versions:

Steps to reproduce:

Related Issues:

Akila94 commented 2 weeks ago

Verified as fixed