wsp-sag / Lasso

Python package of utilities for Network Wrangler
https://wsp-sag.github.io/Lasso/
Apache License 2.0
5 stars 3 forks source link

Modify `write_roadway_as_fixed_width` to not use tokens #128

Open DavidOry opened 3 years ago

DavidOry commented 3 years ago

User Story

A Met Council staff person is writing out the Network Wrangler network as Cube fixed width files. The current method writes out a Cube script that uses tokens to identify the location of the links text file, the nodes text file, and the number of zones. This makes the resulting script confusing (where do these tokens come from?) and requires the script to use a batch file -- which is not provided in the repository.

Priority

Low

Level of Effort

Level

Resolution Ideas

Replace the tokens with the filenames passed into the argument. Replace the zones token with a parameter stored in the parameters file.

Project

No

Who should be involved?

Implementer: @DavidOry Commenters: @RachelWikenMC Users: @RachelWikenMC Reviewers: @i-am-sijia

Risk

Need to review MTC's implementation and compatibility with on-going refactoring

Tests

No automated tests are needed. Tests of existing notebooks confirm correct implementation.

DavidOry commented 3 years ago

@i-am-sijia Can you please have a look at my last commit and see if we need to update anything for MTC in the short run?

i-am-sijia commented 3 years ago

@DavidOry: made changes to MTC Lasso