wsp-sag / Lasso

Python package of utilities for Network Wrangler
https://wsp-sag.github.io/Lasso/
Apache License 2.0
5 stars 3 forks source link

[FEATURE] Flexible CRS #135

Open e-lo opened 2 years ago

e-lo commented 2 years ago

User Story

As a Lasso user, I'd like to be able to create project cards using a network from a different projections As a Lasso user, I'd like to be able to write networks to a projection which I specify

Issue Checklist

Priority

High

Level of Effort

Low-medium

Resolution Ideas

Use code implemented for MTC.

Project

MetCouncil

Who should be involved?

Users: @RachelWikenMC Reviewers: @i-am-sijia

Risk

Will this potentially break anything? Low

Tests

What are relevant tests or what tests need to be created in order to determine that this issue is complete? Will write one

e-lo commented 2 years ago

@RachelWikenMC @DavidOry I just want to make sure I understand the problem appropriately...the develop branch currently allows you to specify the output CRS for the network either when doing the write-out or in the parameters:

roadway_standard_to_met_council_network(self, output_epsg=None):

Is this not working? Or is this not part of the problem you need fixing?

DavidOry commented 2 years ago

Thanks @e-lo. The issue is not writing the network. The issue is:

  1. We make an edit in Cube and record a log file.
  2. Because the Cube network is in the model CRS, the log file records new nodes in the model CRS.
  3. Network Wrangler is expecting lat/lng CRS. So when the Project Card is read in, it fails.

For MTC, @i-am-sijia added functionality to write out the Project Card in lat/lng CRS.

RachelWikenMC commented 2 years ago

Thanks @DavidOry , I was out yesterday. That correctly summarizes the issue. I need the create project card step to output in lat/long and not model CRS. Currently having to correct project cards by hand for new node coordinates.