search

wsp-sag / Lasso

Python package of utilities for Network Wrangler
https://wsp-sag.github.io/Lasso/
Apache License 2.0
5 stars 3 forks source link

geopandas version #141

Open i-am-sijia opened 2 years ago

i-am-sijia commented 2 years ago

The current installation installs the latest geopandas available from conda-forge, which is fine. However, some geopandas methods are updated in newer versions, e.g. op= in geopandas.sjoin() is deprecated in newer versions, and replaced by predicate=.

I updated the sjoin() calls in Lasso to use predicate=, but it crashed Rachel's runs, because she has an older version of geopandas that does not recognize predicate=.

Moving forward, we will add a version requirement on geopandas installation.

@RachelWikenMC @DavidOry

RachelWikenMC commented 2 years ago

What can I do to make this work on my end now?

e-lo commented 2 years ago

@i-am-sijia : you should do an if/then on the geopandas version:

if gpd.version> XX: do new version else: do old version

i-am-sijia commented 2 years ago

https://github.com/Metropolitan-Council/project_card_registry/commit/945a60783ec1bf8f4e7e3862c92a84a64362afc2