wsp-sag / Lasso

Python package of utilities for Network Wrangler
https://wsp-sag.github.io/Lasso/
Apache License 2.0
5 stars 3 forks source link

Remove any hard-coded paths #39

Closed e-lo closed 4 years ago

e-lo commented 4 years ago

i.e. Z:/Sijia... :-)

e-lo commented 4 years ago

@i-am-sijia i think there is just one left in transit.py:

bus_routetype_gdf = gpd.read_file(
            "Z:/Data/Users/Sijia/Met_Council/GIS/shp_trans_transit_routes/TransitRoutes.shp"
        )
i-am-sijia commented 4 years ago

moved that file to parameter, commit ae08494

I guess we can remove this chunk:

https://github.com/wsp-sag/Lasso/blob/ae0849474d785c33677f3bb7edce550e0e9139ee/lasso/transit.py#L63-L66

e-lo commented 4 years ago

I actually updated how cube modes are calculated to be based on the route id and name:

I think this is a pretty good approximation and that way we don't need an extraneous shape file.

https://github.com/wsp-sag/Lasso/blob/47499c386cb8ba2862aaa9acffd509cbd94cfad0/lasso/transit.py#L1016-L1065