wsp-sag / language-gisdk

Atom syntax highlighting for GISDK scripts
MIT License
1 stars 3 forks source link

Added libgisdk from repo to pattern #1

Closed stanvir closed 7 years ago

stanvir commented 7 years ago

Currently the GISDK functions are not recognized by the atom editors. This tweak may enable syntax highlighting for functions.

dkyleward commented 7 years ago

This would obviously be an awesome improvement. I'm not familiar with how this repo integrates (or doesn't) with Atom. Is there any way for us to check that this works before making these changes live?

Added @gregmacfarlane back as a collaborator for any advice he can add.

stanvir commented 7 years ago

Thanks Kyle. I have made some other changes and currently testing the integration with Atom. You can go to my fork at https://github.com/stanvir/language-gisdk and download the repo. After downloading, you need to-

  1. Unzip it
  2. [for windows machine] put it in your /.atom/packages folder
  3. Restart atom
  4. Go to File> Settings> Packages
  5. Install it and check with a new .rsc file

I would appreciate any feedback you can give.

Thanks, Shams

On Fri, Sep 22, 2017 at 8:37 AM, Kyle Ward notifications@github.com wrote:

This would obviously be an awesome improvement. I'm not familiar with how this repo integrates (or doesn't) with Atom. Is there any way for us to check that this works before making these changes live?

Added @gregmacfarlane https://github.com/gregmacfarlane back as a collaborator for any advice he can add.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pbsag/language-gisdk/pull/1#issuecomment-331434883, or mute the thread https://github.com/notifications/unsubscribe-auth/AHR7FeoORYuzYGF0-LtifXDMVzgANDN3ks5sk6oLgaJpZM4PZGLS .

-- Shams Tanvir Assistant Professor Department of Civil Engineering Bangladesh University of Engineering and Technology Dhaka-1000

dkyleward commented 7 years ago

You'll see I made a few small changes, but it looks great! I really like the snippets! As I look through, I see a few more things that we can improve, but this pull request was good to go.