wsp-sag / network_wrangler

A Python Library for Managing Travel Model Network Scenarios
https://wsp-sag.github.io/network_wrangler/
Apache License 2.0
13 stars 3 forks source link

Confirm desired behavior and parameterization for when an existing value is specified in project card but doesn't match. #366

Open e-lo opened 1 month ago

e-lo commented 1 month ago

Desired outcome: have a mechanism for a user be able to upgrade a warning to an error in the main wrangler API or configuration options.

Right now (in v1 RC)

Options

(not mutually exclusive)

In ascending order of complexity to implement:

  1. Add as a parameter in params.py which would set the default behavior.
  2. Add as a scenario configuration parameter which would then change how a scenario behaved.
  3. Add as a parameter that can be set within a ProjectCard at a project level.

Recommendation

My (@e-lo ) recommendation is to implement 1 and if there is a use case for it, 2 but hold off on 3 because it would be more invasive and subject to fiddling and a lot of other cascading decisions.

Thoughts: @lmz @i-am-sijia @yueshuaing @DavidOry @RachelWikenMC ?

e-lo commented 1 month ago

Confirmed 1 and 2 are ok for v1 with @lmz and that project-card level functionality could be improvised by commenting out existing in project card.