nelantone commented 7 years ago

Add the RSpec dependency needed in order to fix Rspec-Sidekiq tests.
Add be_deadable matcher & tests
Make little refactoring

Thanks to @pavel-jurasek-bcgdv-com for the support/help.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.361% when pulling 948d4cf0583a4973e62ff90aa2993a013e427c72 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.375% when pulling b686a6dc43273df338aaec87a734983a4f5a17aa on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

nelantone commented 7 years ago

Hi @packrat386 & @mathieujobin,

We know be_deadable sounds weird but explains much better what the test is doing. be_dead sounds like you are testing if the job is dead. But what we want to do is different. we are checking if the class has the option :dead

Of course we are open to discuss about it and we will be happy to read some feedback for you guys.

Thanks :)

nelantone commented 7 years ago

Hi guys! @packrat386 @mathieujobin Let me know if I can help you somehow in order to change and hopefully merge this branch :).

nelantone commented 7 years ago

@philostler do you have some news about this PR ? Actually I'm using 'be_deadable' and I'm looking froward to take out from my code and use it from the rspec-sidekiq gem. Waiting for some feedback & hopefully you can :shipit: soon :)

packrat386 commented 7 years ago

Thanks for keeping this up to date, I should be able to take a look at it soon.

packrat386 commented 7 years ago

119 is merged if you want to rebase this, but every time I come back to this, it seems like a lot of framework for a matcher to essentially just check what's in the job options. Can you not just do `expect(JobClass.get_sidekiq_options[:dead]).to be_truthy`?

wspurgin / rspec-sidekiq

Add be_deadable matcher * Waiting for #119 to add RSpec Fix #118

119 is merged if you want to rebase this, but every time I come back to this, it seems like a lot of framework for a matcher to essentially just check what's in the job options. Can you not just do `expect(JobClass.get_sidekiq_options[:dead]).to be_truthy`?

wspurgin / rspec-sidekiq

Add be_deadable matcher * Waiting for #119 to add RSpec Fix #118

119 is merged if you want to rebase this, but every time I come back to this, it seems like a lot of framework for a matcher to essentially just check what's in the job options. Can you not just do expect(JobClass.get_sidekiq_options[:dead]).to be_truthy?

119 is merged if you want to rebase this, but every time I come back to this, it seems like a lot of framework for a matcher to essentially just check what's in the job options. Can you not just do `expect(JobClass.get_sidekiq_options[:dead]).to be_truthy`?