search

wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
651 stars 133 forks source link

Show have_enqueued_job deprecation warning only when called #128

Closed foobear closed 7 years ago

foobear commented 7 years ago

Currently, when rspec-sidekiq is loaded, it always prints this deprecation warning:

[DEPRECATION] `have_enqueued_job` is deprecated.  Please use `have_enqueued_sidekiq_job` instead.

This PR ensures that the warning is only shown when the method is actually called.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 91.413% when pulling 675ee4fe927d5790592add1a03fd327c9f74a989 on makandra:fix-deprecation-warning into fc0e1f754b05a1796b9855971144ed2c1b2252b9 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 91.413% when pulling 675ee4fe927d5790592add1a03fd327c9f74a989 on makandra:fix-deprecation-warning into fc0e1f754b05a1796b9855971144ed2c1b2252b9 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 90.859% when pulling 04896412eb8e8c959cca169a45f34d6512d625f2 on makandra:fix-deprecation-warning into fc0e1f754b05a1796b9855971144ed2c1b2252b9 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 90.859% when pulling 04896412eb8e8c959cca169a45f34d6512d625f2 on makandra:fix-deprecation-warning into fc0e1f754b05a1796b9855971144ed2c1b2252b9 on philostler:develop.

packrat386 commented 7 years ago

Closed in favor of #130