search

wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
662 stars 133 forks source link

Test against multiple versions of Sidekiq #129

Closed foobear closed 7 years ago

foobear commented 7 years ago

Tests currently pass for Sidekiq 3 and 4, but fail for Sidekiq 5 (which is not in the scope of this issue ;)).

We've solved the issue of breaking APIs by testing against multiple versions using https://github.com/makandra/gemika. If this sounds good to you, I'd go ahead and add it to rspec-sidekiq.

What do you think?

packrat386 commented 7 years ago

I'd rather just test by using separate gemfiles. See here for example.

Is Sidekiq 3 still maintained? Because if not I'm probably going to err on the side of not testing for it.

foobear commented 7 years ago

I'd rather just test by using separate gemfiles. See here for example.

That's what Gemika does. :) It's more of a convenience wrapper to test against all Gemfiles (and support multiple Ruby versions).

Is Sidekiq 3 still maintained? Because if not I'm probably going to err on the side of not testing for it.

I honestly don't know. :) It seems old versions don't get updates, so it's a perfectly valid option to drop support for Sidekiq <5.

Was just wondering if the goal was to support multiple versions of Sidekiq, and when tests for Sidekiq 5 would pass. Since it seems to have been solved with #130 (thanks!), we can close this issue.