wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
662 stars 133 forks source link

Fix tests and deprecations with Sidekiq 5 #130

Closed packrat386 closed 7 years ago

packrat386 commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 89.722% when pulling d2bb4466516d86d862dc80e1e59572ed76e852ec on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 89.722% when pulling d2bb4466516d86d862dc80e1e59572ed76e852ec on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 89.722% when pulling d2bb4466516d86d862dc80e1e59572ed76e852ec on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d4746190e7767c45d82aaaf1d884909af30b531 on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d4746190e7767c45d82aaaf1d884909af30b531 on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d4746190e7767c45d82aaaf1d884909af30b531 on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d4746190e7767c45d82aaaf1d884909af30b531 on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d4746190e7767c45d82aaaf1d884909af30b531 on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

mlarraz commented 7 years ago

This is not actually removed in Sidekiq 5, just disabled by default. See: https://github.com/mperham/sidekiq/blob/master/5.0-Upgrade.md

You just need to put something like

Sidekiq::Extensions.enable_delay! if Sidekiq::VERSION > 4

in your test setup.

trev commented 7 years ago

@packrat386

The BeDelayed matcher can still work in Sidekiq 5+ if enabled: https://github.com/mperham/sidekiq/blob/master/5.0-Upgrade.md#whats-new

I enable in order to test here: https://github.com/philostler/rspec-sidekiq/pull/126/files#diff-93830fa29d616f7c87903d08b5b1b29aR25

trev commented 7 years ago

Beat me to the punch @mlarraz!

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85b52e04e8c11f4edaa816ed892234d3e4d on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85b52e04e8c11f4edaa816ed892234d3e4d on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85b52e04e8c11f4edaa816ed892234d3e4d on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85b52e04e8c11f4edaa816ed892234d3e4d on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85b52e04e8c11f4edaa816ed892234d3e4d on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.7%) to 97.778% when pulling 32d2f99756b23abb391830e69dffa8b89b7e524b on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.7%) to 97.778% when pulling 32d2f99756b23abb391830e69dffa8b89b7e524b on packrat386:fix_sidekiq_5 into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

packrat386 commented 7 years ago

@trev cherry-picked your commits in here so I can make one green PR.