search

wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
651 stars 133 forks source link

Fix deprecation #131

Closed trev closed 7 years ago

trev commented 7 years ago

Fix deprecation as per https://github.com/philostler/rspec-sidekiq/pull/126

The test will fail for 2 reasons:

  1. Sidekiq 5.0 has the delayed extension disabled by default and must be enabled. (Solved by https://github.com/philostler/rspec-sidekiq/pull/132)
  2. Sidekiq 5.0 doesn't support Ruby < 2.2.2 (Solved by https://github.com/philostler/rspec-sidekiq/pull/130)
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 91.667% when pulling 7392d77b731d5482581ca53af05a3ca573259c88 on trev:fix_deprecation into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 91.667% when pulling 7392d77b731d5482581ca53af05a3ca573259c88 on trev:fix_deprecation into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

trev commented 7 years ago

Based on feedback from #128 & #105 which this PR solves.

tisba commented 7 years ago

Is there something we can do to get this merged?

trev commented 7 years ago

Closed in favour of #130