Enable Sidekiq delay extension for >5.0.0

wspurgin / rspec-sidekiq

RSpec for Sidekiq

https://github.com/wspurgin/rspec-sidekiq

Other

662 stars 133 forks source link

Enable Sidekiq delay extension for >5.0.0 #132

Closed trev closed 7 years ago

trev commented 7 years ago

As per https://github.com/philostler/rspec-sidekiq/pull/130#issuecomment-306683365 Sidekiq >5.0.0 is the delayed extension disabled by default. We therefore enable the extension to test properly.

Note: Some tests will still fail since Sidekiq >5.0.0 requires Ruby >=2.2.2. The PR https://github.com/philostler/rspec-sidekiq/pull/130 should address those failures.

coveralls commented 7 years ago

Coverage increased (+6.1%) to 97.222% when pulling 0a8a1f9de40b173cf24600d9b9a3c3be1da46aa6 on trev:fix-sidekiq-test into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

coveralls commented 7 years ago

Coverage increased (+6.1%) to 97.222% when pulling 0a8a1f9de40b173cf24600d9b9a3c3be1da46aa6 on trev:fix-sidekiq-test into ac4528ecff541242daa6145c24780d50ee06e4a0 on philostler:develop.

tisba commented 7 years ago

Is there something we can do to get this merged?

packrat386 commented 7 years ago

I'm working on it, please be patient. I want to get all these working again without introducing too many artifacts of the application of several half measures. I'm going to try to pull these changes into a single PR, resolve conflicts, and then merge that.

tisba commented 7 years ago

I'm sorry, it wasn't my intention to make pressure. Take your time and let me/us know if we can help in any way.

trev commented 7 years ago

Closed in favour of #130