search

wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
662 stars 133 forks source link

Support Class#method notation in batch callback #155

Closed caalberts closed 4 years ago

caalberts commented 6 years ago

Sidekiq Pro batch callback feature supports the Class#method notation when registering a callback. It's documented here.

This commit adds support for it in NullBatch.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 97.101% when pulling 56fcf12302de9240059c7b8c2a972cbb625aea66 on caalberts:batch-callback into 12135312a7868353a51586bf97489dd2c3f0846d on philostler:develop.

packrat386 commented 4 years ago

Hey y'all. As you can probably tell, this repo is in need of a bit of TLC and I haven't been able to spend all that much time on it. I'm planning to spend some time this weekend to go through outstanding pull requests that can be merged and then cutting a new version. I know it's been a while since there have been any updates, so thanks for your patience.

packrat386 commented 4 years ago

These changes have been pulled into 3.1.0