remove deprecated method "have_enqueued_job"

wspurgin / rspec-sidekiq

RSpec for Sidekiq

https://github.com/wspurgin/rspec-sidekiq

Other

651 stars 133 forks source link

remove deprecated method "have_enqueued_job" #175

Closed stereosupersonic closed 11 months ago

stereosupersonic commented 3 years ago

this deprecated method collide with the one from rspec https://relishapp.com/rspec/rspec-rails/docs/matchers/have-enqueued-job-matcher

coveralls commented 3 years ago

Coverage decreased (-0.07%) to 97.458% when pulling 4a7d20f7213b899d96e55c2fba57b36d68114c7c on konvenit:develop into ccce13c71ebfe848bc35ec79fc62f63714f9e3e1 on philostler:develop.

coveralls commented 3 years ago

Coverage decreased (-0.07%) to 97.458% when pulling 4a7d20f7213b899d96e55c2fba57b36d68114c7c on konvenit:develop into ccce13c71ebfe848bc35ec79fc62f63714f9e3e1 on philostler:develop.

coveralls commented 3 years ago

Coverage decreased (-0.07%) to 97.458% when pulling 4a7d20f7213b899d96e55c2fba57b36d68114c7c on konvenit:develop into ccce13c71ebfe848bc35ec79fc62f63714f9e3e1 on philostler:develop.

coveralls commented 3 years ago

Coverage decreased (-0.07%) to 97.458% when pulling 4a7d20f7213b899d96e55c2fba57b36d68114c7c on konvenit:develop into ccce13c71ebfe848bc35ec79fc62f63714f9e3e1 on philostler:develop.

coveralls commented 3 years ago

Coverage decreased (-0.07%) to 97.458% when pulling 4a7d20f7213b899d96e55c2fba57b36d68114c7c on konvenit:develop into ccce13c71ebfe848bc35ec79fc62f63714f9e3e1 on philostler:develop.

coveralls commented 3 years ago

Coverage decreased (-0.07%) to 97.458% when pulling 4a7d20f7213b899d96e55c2fba57b36d68114c7c on konvenit:develop into ccce13c71ebfe848bc35ec79fc62f63714f9e3e1 on philostler:develop.

wspurgin commented 11 months ago

Hi @stereosupersonic there was a lapse in ownership for this gem when you PR was made. I'm planning on deprecating the matcher with V4, so if you're still interested, feel free to rebase this PR (or make a new one) with removing the deprecated have_enqueued_job matcher.

wspurgin commented 11 months ago

I went ahead and tackled this in #199 since I wanted to rename the matcher class to match. Thanks for the original PR!