search

wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
663 stars 132 forks source link

Issue with yaml safe loading (psych gem) #177

Closed Paul-Yves closed 1 year ago

Paul-Yves commented 3 years ago

I am trying to upgrade to psych 4 but there are breaking changes on yaml loading and all my expect().to be_delayed breaks.

There are some examples of other library starting to use safe load.

See for example #503 where the library adapted to the changes: sparklemotion/http-cookie#34.

Is it something rspec-sidekiq would consider do ?

Paul-Yves commented 3 years ago

The gem I use no longer has dependency to psych so I no longer have the issue, however I guess that the issue remains for those who upgrade psych version.

wspurgin commented 1 year ago

Thank you for the issue! Many years late but I think this will be fixed in V4 with https://github.com/wspurgin/rspec-sidekiq/commit/8fc3f9dca869eb746c88902afe72f2255108524d#diff-8198780b626ed0023b2808c305db028adadd80c82bb05a64f600a3f47b93f1b0R61-R66