Closed ericproulx closed 5 months ago
Thanks Eric! As suspected (since this is a rather old gem), we have a lot of string mutating that we're doing. If you're up for taking a crack at the substantial refactor, feel free to get cracking on it.
:bulb: Of course, the easier first step might be to put frozen_string_literal: false
in any place (mostly specs) where it's currently not compatible with frozen string literals.
Either way, thanks for suggesting the changes!
Thanks Eric! As suspected (since this is a rather old gem), we have a lot of string mutating that we're doing. If you're up for taking a crack at the substantial refactor, feel free to get cracking on it.
💡 Of course, the easier first step might be to put
frozen_string_literal: false
in any place (mostly specs) where it's currently not compatible with frozen string literals.Either way, thanks for suggesting the changes!
I've fixed the issue. I don't know why it was only on 2.7.
@wspurgin I ran the workflow on my fork and everything is green. I've added a few things along the way
Since Ruby 3.4 will consider String literals in files without a frozen_string_literal comment as if they were frozen, I took the opportunity to add its.