search

wstrange / asn1lib

Dart ASN1 Encoder / Decoder
BSD 2-Clause "Simplified" License
30 stars 31 forks source link

Add ASN1IpAddress object to better support SNMP applications #47

Closed point-source closed 4 years ago

point-source commented 4 years ago

Note that since this is an SNMP-specific feature, I have not added the ASN1pAddress object to the parser since tag 0x40 may not always mean IP_ADDRESS in all cases. Still, having this object available in the library extends the useability of this library in SNMP applications.

point-source commented 4 years ago

Happy to bump to whatever you like, not sure what the .1 is to signify here though since I already moved from 0.7.0 to 0.8.0 with this PR. Unless you are referring to the combination of this PR and my other one.

wstrange commented 4 years ago

Happy to bump to whatever you like, not sure what the .1 is to signify here though since I already moved from 0.7.0 to 0.8.0 with this PR. Unless you are referring to the combination of this PR and my other one.

Yea - I got a bit confused here. Do you want this PR to go in first?

If so - then the next PR should probably be 0.8.1 to signal a possible (non breaking) change in behavior?

point-source commented 4 years ago

I had originally assumed the bug fix would go in first mostly because new features usually take more review / testing but since you're good with both, I am happy to go in any order you want. I actually have another one coming with a fix for oids that have a zero-octet. If you would prefer me to merge these together, I can. I've just had maintainers in the last ask me to keep them separate so they can choose what goes/what doesn't. But doing it that way puts the burden of updating the version on the maintainer.

Edit: Probably makes sense to do the bug fix first and then this one. After you merge the fix, I will correct any conflicts on this branch.

wstrange commented 4 years ago

OK - first PR merged!

point-source commented 4 years ago

Conflicts resolved

wstrange commented 4 years ago

Merged - and thanks so much for your help!

I'll push the new version to pub ASAP

point-source commented 4 years ago

Haha no problem! Happy to help. I got one more PR coming, can push after that haha.