search

wstrange / asn1lib

Dart ASN1 Encoder / Decoder
BSD 2-Clause "Simplified" License
30 stars 31 forks source link

Add support for BMPString #58

Closed declanwoods closed 3 years ago

declanwoods commented 3 years ago

Hi, I recently needed support for BMPString, so I have added it. Please let me know if you need anything to change.

wstrange commented 3 years ago

This looks great - Thanks Declan!

Can you bump the version in pubspec to 1.0.3 and add a changelog.md entry. After that I'll merge and push a new version to pub.

declanwoods commented 3 years ago

Done @wstrange ​:)​

wstrange commented 3 years ago

Almost there! Can you run dartfmt. The PR check is failing on: Changed lib/asn1bmpstring.dart Changed lib/asn1parser.dart

wstrange commented 3 years ago

Thanks Declan - much appreciated!

I pushed the new package to pub.dev