A lot of cleanup - Githubissues

wstrange / asn1lib

Dart ASN1 Encoder / Decoder

BSD 2-Clause "Simplified" License

30 stars 31 forks source link

A lot of cleanup #64

Closed kevmoo closed 1 year ago

kevmoo commented 1 year ago

Made a number of APIs not-nullable
Made a number of fields final where they could be
Added types to a few public APIs
Enabled and fixed a bunch of new lints
Moved part files to the lib/src dir
Require Dart 3

kevmoo commented 1 year ago

Ooo...looks like CI might be turned off for your repo 🤷

wstrange commented 1 year ago

Hi Kev - this looks awesome. Not sure why the CI is not running... let me take a look

wstrange commented 1 year ago

I think GH disabled the workflow after 60 days. I'm going to merge this now (assuming you've run all tests/) - and I'll figure out how to enable CI later.

Thanks so much for this PR!