HW5 ready for grading!

[wswade2]

Click here for HW5.

[wswade2]

@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

[ChadFibke]

Readme/repo comments:

Pros-

• Short and sweet!

Cons/improvments-

• I could not find one large, collapsed repo with all of the homework named in a descriptive manner. I think having no Index/organization may cause you some pain in the future (you'll have to look through a lot of repos with no informative names when trying to find something).

.Rmd/.md comments:

Pros- +Provides some comments that are easy to follow along!

• Provides sufficient evidence for removing Oceania rows, BUT you never dropped the unused factors belonging to Oceania!
• It is clear you have improved you data visualization skills!!! (I really liked the graphics you used.)
• I think you went above and beyond the expected use of forcats, and it was a good idea to reinforce your changes with graphs!
• Code looks good!
• I can relate with your reported progress. Too true!

Cons-

• In the future try to avoid assigning to uninformative objects ("gap", "g", "g2"). This will be confusing and more prone to error (overwriting objects)
• I think you're missing some comments as to why you used some functions. For example, did you use sapply? For me it seemed to come out of nowhere, but if you had comments about why you used it I'm sure it would help with the work flow!
• Something went wrong with the .jpg! I had the same issue so I feel your pain!
• The order of the tasks you complete is out of order of the assignment, so It makes it a little harder to review!

General

• looks like you put a lot of effort in, and also made comments that made your report fun to read, but there were still some tasks uncompleted.

• I think you have learned a lot/greatly improved you data visualization skills!

• I think you did good 👍

[KateJohnson]

Nice work @wswade2 👍

• Repo organization: Can you bring all of your homework assignments into a single repo? It might be nicer for referring back to. Also in general it would be good to name your homework and the repo according to the content, ie. Factors and figure management

Factors:

• I’m guilty of this too, but you could consider showing the data using kables for nicer formatting.
• I think you could have showed more clearly that the Oceania level remained even after filtering it out using levels(gapminder.no$continent). I also didn’t really understand where you dropped the factor levels, it doesn’t look like you used fct_drop() after filtering Oceania out.
• Good reordering of the data so Oceania is at the bottom.

Data visualization:

• I agree your revamped pie chart looks cool, but I had a hard time understanding what it was showing, maybe a bit too much going on as you said. But it was original and I’m glad to know how to make it now :)
• I see you saved the plot but didn’t link it back into the markdown file, I think you just need instead of the entire path name and then the file should show up.

File I/O:

• Nice work. I generally use read.table to load csv files and you can specify header=TRUE with that command.

[pgonzaleze]

Hi @wswade2 here are some comments about your homework: Reorder a factor: yes File I/O: yes Implement visualization: yes Write data to file: yes Clean up: no, one repo per assignment Extras: No

Part I

• Good explanations before and after dropping Oceania, it was brief but reasonable,
• I would recommend that when assign names try to give one more descriptive, avoid use one character this could be confusing for the readers and also for you after some time,
• I don´t think that the pie chart is the best option to show what you want, anyway it was a good exploration of its arguments,

  Part II

• Good practice

  Part III

  +Good exploration. Pay attention to the comments of your reviewers.

  Part IV

• The ggsave function is correct, the link could be the path to github location of your figure.

  Part V

• You have one repo for each assignment, you can try to rename any of those and bring everything to only one. To rename a repo, go to settings and then rename repository.

Good work, you have learned good things now its time to apply them in the real world with your data, Your grades would be distributed later, Regards,

Pedro G.