wswebcreation / protractor-image-comparison

npm-module to compare images with protractor
86 stars 38 forks source link

Test on some browsers fail due to syntax error #14

Closed wswebcreation closed 7 years ago

wswebcreation commented 7 years ago

Issue:

Test fail when getting the browserdata

Steps to reproduce:

Execute a testcase on IE11, it will give a failure with a stacktrace that the methods didn't received a result after 25 seconds

Cause

        function retrieveData(isMobile, addressBarShadowPadding, toolBarShadowPadding) {
            return {
                // Used a , instead of - for toolBarShadowPadding
                fullPageHeight: document.body.scrollHeight - addressBarShadowPadding, toolBarShadowPadding,
                fullPageWidth: document.body.scrollWidth,
                height: isMobile ? window.screen.height : window.outerHeight,
                pixelRatio: window.devicePixelRatio,
                viewPortWidth: document.body.clientWidth,
                viewPortHeight: window.innerHeight,
                width: isMobile ? window.screen.width : window.outerWidth
            };
        }
wswebcreation commented 7 years ago

Fixed with new release