search

wswebcreation / protractor-image-comparison

npm-module to compare images with protractor
86 stars 38 forks source link

Ignore regions by making them transparent in the base image #31

Closed tharders closed 7 years ago

tharders commented 7 years ago

Hi, I had the idea, that it would be nice to mark regions that should be ignored for comparison in the base image, which would be easier than working with blockout rectangles in the code. Since a screenshot would normally not contain transparency, I had the idea to make the regions that shall be ignored transparent in the base image. So I added a new option ignoreTransparentPixel that can be set to true to ignore pixels that have transparencies. I updated the unit tests together with a new test image.

But "npm run test" did not work for me, even before I made my changes. I tried it on windows and a fellow on Mac.

I hope you also like the idea and will add the feature into this cool project. If you have feedback, I am happy to work on this.

Thanks... Thorsten

wswebcreation commented 7 years ago

Hi @tharders

Tnx for your PR. The idea sounds good and I'll review your PR and feedback the coming days. I'm currently not in a good mode to do that (something with sun and a holiday ;-))

wswebcreation commented 7 years ago

@tharders

Tnx for for the PR, I've merged it. I first need to fix my build and will then make a new release