search

wswebcreation / protractor-image-comparison

npm-module to compare images with protractor
86 stars 38 forks source link

Hook to protractor-multiple-cucumber-html-reporter-plugin #49

Closed spwizard closed 6 years ago

spwizard commented 6 years ago

Hi I am currently using your html reporter plugin, and it would be great if we could actually show the baseline/actual/diff images when a comparison fails.

Have you any suggestions how I could hook into an assertion fail event.

wswebcreation commented 6 years ago

Hi @spwizard

This is possible, but would need some custom work from your side. The protractor-cucumber-html-plugin doesn't hold the mechanisme to create screenshots on failure, you create it yourself in a After-hook.

I've done this before for a client 1,5 years ago and will check if I remember how. I'll add a example script / link to it in here within a few days

spwizard commented 6 years ago

Hi Thanks that would be great. We have some horrible Java application that does our visuals at the moment and this solution of yours just fits nicely with the reporter and our cucumber tests

Thanks Rob

Sent from my iPhone

On 21 Feb 2018, at 06:21, Wim Selles notifications@github.com wrote:

Hi @spwizard

This is possible, but would need some custom work from your side. The protractor-cucumber-html-plugin doesn't hold the mechanisme to create screenshots on failure, you create it yourself in a After-hook.

I've done this before for a client 1,5 years ago and will check if I remember how. I'll add a example script / link to it in here within a few days

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

spwizard commented 6 years ago

Any update on this, thanks

wswebcreation commented 6 years ago

Sorry, no, currently to busy in preparing presentations, sorry

damonpam commented 6 years ago

Hi @wswebcreation, what is the status on this? It would be great to use both tools together! Any idea about how can we customise the After-hook? In your solution, was it possible to add a concrete diff file? thanks!

wswebcreation commented 6 years ago

Hi @spwizard and @damonpam

I've been to busy the last weeks. I've added a gist with some code of an old project. I hope you understand how I did it. This is the way to attach the difference to the cucumber report file.

https://gist.github.com/wswebcreation/31730968eff3ac654555f64a706409cb

I don't know if it works, but feel free to edit it

Grtz

Wim