wswebcreation / protractor-image-comparison

npm-module to compare images with protractor
86 stars 38 forks source link

Check full element #52

Closed woutercr closed 6 years ago

woutercr commented 6 years ago

It happens that an element does not fit on the screen. It would be very welcome if it became possible to compare such an element completly and not just the on screen part.

wswebcreation commented 6 years ago

Hmm,

Based on the core it's currently not possible, we because we crop an element out of a screenshot of the viewport. I'm also, for the refactor, looking for a new / better way of getting screenshots, I'll take this situation into account.

woutercr commented 6 years ago

Thinking out loud: would it be possible to crop the element image from a fullpage screenshot?

wswebcreation commented 6 years ago

Yep

That's a solution, but it's more complex because the module doesn't know the size before making the screenshot, that means the logic needs to be refactored which has more impact. I'd rather investigate in a new way then refactoring to much

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.