search

wswebcreation / protractor-image-comparison

npm-module to compare images with protractor
86 stars 38 forks source link

set imageHeight correctly, if screens.length === 1 #54

Closed JochenDiekenbrock closed 6 years ago

JochenDiekenbrock commented 6 years ago

I could reproduce Issue 44 Argument should be a buffer. In my case, it happened in headless Chrome. I found that this issue happens, if _saveFullScreenshot is called with screens.length === 1. I fixed this by setting the inital value to from screens[0]

wswebcreation commented 6 years ago

@JochenDiekenbrock

Tnx man, I didn't have time to look into it the last weeks. Will look into this this weekend and if all is OK will create a new release

JochenDiekenbrock commented 6 years ago

Hi Wim, I changed the fix, this works fine in my tests as well.