wswebcreation / webdriver-image-comparison

MIT License
43 stars 36 forks source link

[issue] #103 The percentage difference is rounded and passes the tests #105

Closed jesusfj710 closed 1 year ago

jesusfj710 commented 2 years ago

https://github.com/wswebcreation/webdriver-image-comparison/issues/103

jesusfj710 commented 2 years ago

I'm sorry I haven't had time to check it, but I need to find the right time. I will probably go over and do another draft that is more complete and then we can discuss it.

jesusfj710 commented 2 years ago

@wswebcreation maybe now? 🤔

wswebcreation commented 1 year ago

Thanks @jesusfj710

I'll check this one later. This might be a breaking change and will need to update at least the https://github.com/wswebcreation/wdio-image-comparison-service module.

Will put this on my TODO list.

wswebcreation commented 1 year ago

Thanks for you work. This will be a breaking change because it will now by default return 0.00 instead of 0. I'm going to release this in a few days because I want to fix some more things

wswebcreation commented 1 year ago

@jesusfj710

I've been thinking about this and I had a lot of breaking tests, so I reverted your PR and updated it to the following https://github.com/wswebcreation/webdriver-image-comparison/releases/tag/v1.0.2. I hope you don't mind

jesusfj710 commented 1 year ago

Ok, but at some point this should be handled better or at least made clear in the readme.MD or in the wiki how this can affect the use of the library.

wswebcreation commented 1 year ago

Will do that, busy with some last tweaks and will release the package in a few days