issues
search
wswebcreation
/
webdriver-image-comparison
MIT License
43
stars
35
forks
source link
Optimize get page scrollheight
#18
Closed
wswebcreation
closed
5 years ago
wswebcreation
commented
5 years ago
in some cases the default
document.body.scrollHeight
is not sufficient, there can be other factors that influence determining the height of the page
for full page screenshots the scollbars only need to be hidden after a scroll, bot before. This might block scrolling in some situations
in some cases the scroll can't be done on the window, it need to be done on the largest element.
add tests and increase coverage
fix to add
overflow
to the
body
instead of the
html
element
update dependencies
document.body.scrollHeight
is not sufficient, there can be other factors that influence determining the height of the pageoverflow
to thebody
instead of thehtml
element