search

wswebcreation / webdriver-image-comparison

MIT License
43 stars 36 forks source link

fix(hide-remove): use querySelectorAll, mark visited to not repeat #68

Closed kevinlacotaco closed 4 years ago

kevinlacotaco commented 4 years ago

Using devtools protocol the el.style check misses and it ends up thinking it's a single element. This means it marks the same first match hidden multiple times.

By using querySelectorAll first we will be able to capture all valid selection if we have matches. If only one is selected we can still iterate over it that one time.

If we come back into this we wont try to execute again if we have seen the selector.

wswebcreation commented 4 years ago

Released a new version, thanks for the work!