search

wswebcreation / webdriver-image-comparison

MIT License
43 stars 35 forks source link

disableCSSAnimation breaks transform-Transformations #69

Closed michael42 closed 4 years ago

michael42 commented 4 years ago

Config of the automation framework + plugin {disableCSSAnimation: true}

Describe the bug Hi there, thanks for the project. We enabled disableCSSAnimation, so that we don't have to disable animations ourselves. Unfortunately, this caused our page to render incorrectly, so we had to disable it again.

To Reproduce Steps to reproduce the behavior:

  1. Assume a page that uses transform, for example to center elements.
  2. Set disableCSSAnimation: true.
  3. The transform: none !important; now causes the page to render incorrectly.

Expected behavior setCustomCss should simply not set transform: none !important; (and the vendor-prefixed variants).

wswebcreation commented 4 years ago

Hi @michael42

Thanks for this issue, transform is also part of the animations, any idea how to do this better? Also care for a PR?

michael42 commented 4 years ago

Simply removing the lines should work fine (it's what we're currently doing before taking screenshots), as transform is just a static transform. Only animation or transition are actually doing the animation.

wswebcreation commented 4 years ago

@michael42

Thanks for the PR, I've released a new version https://github.com/wswebcreation/wdio-image-comparison-service/releases/tag/v1.13.3