WIP_Issue#28 - Githubissues

wszib-kolo / sapper

sapper

0 stars 2 forks source link

WIP_Issue#28 #49

Closed Kacper3331 closed 6 years ago

Kacper3331 commented 10 years ago

I'm sorry that I made one branch to two Issues but I was working on Issue#28 and somehow started to work on second.

Kacper3331 commented 10 years ago

@unijewski, @sulo61, @job-lukasz, @tinamou could you look at my pull request. I really don't know if what I did is correct or not. That's why I will be really grateful If you could tell me what is wrong. If everything is wrong then I will start over.

mkasztelnik commented 10 years ago

Maybe instead of static field you can create instance of GuiOptions and pass it into every view which require it.

Kacper3331 commented 10 years ago

Could you give me example how to do it in command line? I'm afraid that I will screw up something.

mkasztelnik commented 10 years ago

@Kacper3331 you already have PR :) Sorry for disturbing

mkasztelnik commented 10 years ago

@Kacper3331 my propositions:

in the whole game create one instance of GameOptions (most probably in Bridge)
When creating new view (e.g. GuiOptions, SaperGui) instead of passing sizeX, sizeY, mines paste instance of GameOptions

Other improvements:

GuiOptions right now has public fields, try to use getters and setters instead
Think about read only access to GuiOptions for SaperGui, and read-write access for GuiOptions

ulysses1900 commented 10 years ago

Kacper, I've done some changes that you asked me to. Perhaps it will help.

unijewski commented 10 years ago

:+1: