wszib-kolo / sapper

sapper
0 stars 2 forks source link

Migrate options from HomeScreen to Menu #59

Closed unijewski closed 10 years ago

unijewski commented 10 years ago

I'm waiting for your code review.

unijewski commented 10 years ago

Okay guys, by using the menu we can start a new game, load gui options and close the window. Now a problem is that after changing a size of board or mines we should open a new window and close the previous one. I can see two ways. Before displaying options we close a board and after cancelling we load the previous board thus we don't have a doubled window after saving or we keep the window but after saving new values we have to close the previous board thus we haven't got the doubled window after cancelling. I think the first way is better but what about loading - is it Jasiek's issue more or less?

mkasztelnik commented 10 years ago

@unijewski one question: why do you need 2 windows? Is it not possible to remove panel holding old board, replace it with new one and than change windows size?

ulysses1900 commented 10 years ago

Please add Save button in the menu!

unijewski commented 10 years ago

@tinamou @ulysses1900 Please make a code review.

mkasztelnik commented 10 years ago

Why main game window is closed when I select options from the menu?

mkasztelnik commented 10 years ago

Help Menu does nothing

unijewski commented 10 years ago

@tinamou I couldn't figure out how to close the main (previous) window from GuiOptions.java while saving and starting a new game with a new board. Yeah, I know it. I'll add authors window today or tomorrow, at the latest.

ulysses1900 commented 10 years ago

for me ok

unijewski commented 10 years ago

@ulysses1900 @Kacper3331 Please make a code review.

Kacper3331 commented 10 years ago

I can't find any problems and bug which I mentioned earlier disappear so I am satisfied :+1:

ulysses1900 commented 10 years ago

There is problem: when I hit "Gra", then "opcje" then change options, I cannot do "save" (nothing is happening).

unijewski commented 10 years ago

It's not a bug - this feature isn't implemented in here.

ulysses1900 commented 10 years ago

in that case it's :+1: