getDefiningElement NullPointerException

nicobustillos commented 2 years ago

Plugin Version: 0.5.12 IDEA Version: PyCharm 2021.3.3

java.lang.NullPointerException

``` java.lang.NullPointerException at java.base/java.util.Optional.orElseThrow(Optional.java:408) at at.wtioit.intellij.plugins.odoo.models.impl.OdooModelImpl.getDefiningElement(OdooModelImpl.java:94) at at.wtioit.intellij.plugins.odoo.models.impl.OdooModelImpl.lambda$getDefiningElement$4(OdooModelImpl.java:65) at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:852) at at.wtioit.intellij.plugins.odoo.models.impl.OdooModelImpl.getDefiningElement(OdooModelImpl.java:49) at at.wtioit.intellij.plugins.odoo.OdooGoToDeclarationHandler.getOdooModel(OdooGoToDeclarationHandler.java:63) at at.wtioit.intellij.plugins.odoo.OdooGoToDeclarationHandler.getOdooModel(OdooGoToDeclarationHandler.java:55) at at.wtioit.intellij.plugins.odoo.OdooGoToDeclarationHandler.getGotoDeclarationTarget(OdooGoToDeclarationHandler.java:32) at com.intellij.codeInsight.navigation.actions.GotoDeclarationHandlerBase.getGotoDeclarationTargets(GotoDeclarationHandlerBase.java:14) ... at com.intellij.openapi.application.impl.NonBlockingReadActionImpl$Submission.lambda$transferToBgThread$1(NonBlockingReadActionImpl.java:407) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ... at java.base/java.lang.Thread.run(Thread.java:829) ```

bigbear3001 commented 2 years ago

Notes: not yet reproduced, the issue could happen when:

We get a OdooModelImpl that has an empty list of defining elements
- this should have been fixed in 6e68a1acdb03aad8a1ea00e661f8740381fdf26e (0.4.0)
- https://github.com/wt-io-it/odoo-pycharm-plugin/blob/master/src/main/java/at/wtioit/intellij/plugins/odoo/models/impl/OdooModelServiceImpl.java#L32
- TODO: could such a model still be created?
All Files that define the OdooModelImpl do not match(equal) the base module:
- https://github.com/wt-io-it/odoo-pycharm-plugin/blob/master/src/main/java/at/wtioit/intellij/plugins/odoo/models/impl/OdooModelImpl.java#L55
TODO mark the last processed element (Module, Model, Record) (per thread?) and add it to the error reporter
TODO add the detected Odoo version to the error reporter

bigbear3001 commented 1 year ago

this has been fixed in 0.6.9 (pending JetBrains approval). if you are eager to test the new version, you can use the jar file from https://github.com/wt-io-it/odoo-pycharm-plugin/tree/v0.6.9

ap-wtioit commented 1 year ago

0.6.9 has been approved and is available in the marketplace

wt-io-it / odoo-pycharm-plugin

getDefiningElement NullPointerException #30