search

wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Enable tests with Windows and begin `os.path` → `pathlib` transition #190

Closed namurphy closed 1 year ago

namurphy commented 1 year ago

This is my second attempt to fix an problem with running tests on Windows. I'm attempting this in a different PR because I kept getting a temporary path not found error in #182 that I had trouble tracking down. I had tests passing on my workstation, but an error on GitHub. I'm going to try to track down the exact changes that I made that broke this.

This supersedes #182. Probably.

Closes https://github.com/wtbarnes/fiasco/issues/179. I previously tried Windows tests on https://github.com/wtbarnes/fiasco/pull/176.

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.89% // Head: 86.91% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (e90eb96) compared to base (99dad9e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ========================================== + Coverage 86.89% 86.91% +0.01% ========================================== Files 22 22 Lines 1801 1803 +2 ========================================== + Hits 1565 1567 +2 Misses 236 236 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/util/setup\_db.py](https://codecov.io/gh/wtbarnes/fiasco/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvc2V0dXBfZGIucHk=) | `70.27% <100.00%> (+0.40%)` | :arrow_up: | | [fiasco/util/util.py](https://codecov.io/gh/wtbarnes/fiasco/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvdXRpbC5weQ==) | `47.82% <100.00%> (+0.76%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

namurphy commented 1 year ago

Nevermind! Going back to #182.

The issue was that when doing path.mkdir(), I had to set parents=True to make the parent directory exist also.