wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
21 stars 17 forks source link

Fix free-bound continuum function #196

Closed wtbarnes closed 1 year ago

wtbarnes commented 1 year ago

Fixes #42

This PR is an effort to fix the inconsistency between the free-bound continuum implementation in fiasco versus is what is implemented in CHIANTI IDL. This also adds a suite of tests for comparing against the IDL implementation.

TODOs:

Current progress:

image image

wtbarnes commented 1 year ago

I found two bugs that have FINALLY resolved these inconsistencies:

The updated comparison now looks like the following:

image image

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.92% // Head: 87.03% // Increases project coverage by +0.11% :tada:

Coverage data is based on head (bdaf496) compared to base (dc309d3). Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #196 +/- ## ========================================== + Coverage 86.92% 87.03% +0.11% ========================================== Files 22 22 Lines 1812 1820 +8 ========================================== + Hits 1575 1584 +9 + Misses 237 236 -1 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/collections.py](https://codecov.io/gh/wtbarnes/fiasco/pull/196/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2NvbGxlY3Rpb25zLnB5) | `70.96% <0.00%> (ø)` | | | [fiasco/ions.py](https://codecov.io/gh/wtbarnes/fiasco/pull/196/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvbnMucHk=) | `89.95% <93.75%> (+0.45%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.