Closed wtbarnes closed 1 year ago
I found two bugs that have FINALLY resolved these inconsistencies:
The updated comparison now looks like the following:
Base: 86.92% // Head: 87.03% // Increases project coverage by +0.11%
:tada:
Coverage data is based on head (
bdaf496
) compared to base (dc309d3
). Patch coverage: 85.71% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Fixes #42
This PR is an effort to fix the inconsistency between the free-bound continuum implementation in fiasco versus is what is implemented in CHIANTI IDL. This also adds a suite of tests for comparing against the IDL implementation.
TODOs:
Current progress: