search

wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Miscellaneous fixes in prep for release #197

Closed wtbarnes closed 1 year ago

wtbarnes commented 1 year ago

Fixes #195 Fixes #185 Fixes #193 Fixes #188 Fixes #183 Fixes #181

This is a grab bag of multiple fixes in preparation for a v0.1 release.

@namurphy would you mind giving this a review when you have a chance? In particular, I'd like your opinion on whether #181 has been properly addressed.

codecov-commenter commented 1 year ago

Codecov Report

Base: 87.03% // Head: 86.82% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (1520397) compared to base (c94a6ec). Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ========================================== - Coverage 87.03% 86.82% -0.21% ========================================== Files 22 22 Lines 1820 1829 +9 ========================================== + Hits 1584 1588 +4 - Misses 236 241 +5 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/elements.py](https://codecov.io/gh/wtbarnes/fiasco/pull/197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2VsZW1lbnRzLnB5) | `89.83% <ø> (ø)` | | | [fiasco/ions.py](https://codecov.io/gh/wtbarnes/fiasco/pull/197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvbnMucHk=) | `89.95% <ø> (ø)` | | | [fiasco/util/tools.py](https://codecov.io/gh/wtbarnes/fiasco/pull/197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvdG9vbHMucHk=) | `94.54% <ø> (ø)` | | | [fiasco/util/setup\_db.py](https://codecov.io/gh/wtbarnes/fiasco/pull/197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvc2V0dXBfZGIucHk=) | `67.46% <50.00%> (-3.20%)` | :arrow_down: | | [fiasco/util/exceptions.py](https://codecov.io/gh/wtbarnes/fiasco/pull/197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wtbarnes commented 1 year ago

Thanks @namurphy! Should be fairly close to a release now.