search

wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Increase test coverage for `IonCollection` #198

Closed wtbarnes closed 1 year ago

wtbarnes commented 1 year ago

Also fixes #120

The test coverage for the IonCollection class was particularly bad. This adds a few tests to improve that.

TODO

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.82% // Head: 90.01% // Increases project coverage by +3.18% :tada:

Coverage data is based on head (4de40d0) compared to base (78c672f). Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== + Coverage 86.82% 90.01% +3.18% ========================================== Files 22 22 Lines 1829 1832 +3 ========================================== + Hits 1588 1649 +61 + Misses 241 183 -58 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/util/setup\_db.py](https://codecov.io/gh/wtbarnes/fiasco/pull/198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvc2V0dXBfZGIucHk=) | `67.46% <50.00%> (ø)` | | | [fiasco/collections.py](https://codecov.io/gh/wtbarnes/fiasco/pull/198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2NvbGxlY3Rpb25zLnB5) | `91.20% <100.00%> (+20.23%)` | :arrow_up: | | [fiasco/elements.py](https://codecov.io/gh/wtbarnes/fiasco/pull/198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2VsZW1lbnRzLnB5) | `100.00% <100.00%> (+10.16%)` | :arrow_up: | | [fiasco/ions.py](https://codecov.io/gh/wtbarnes/fiasco/pull/198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvbnMucHk=) | `92.92% <100.00%> (+2.97%)` | :arrow_up: | | [fiasco/util/util.py](https://codecov.io/gh/wtbarnes/fiasco/pull/198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvdXRpbC5weQ==) | `70.42% <100.00%> (+21.85%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.