wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Fix publish CI step and add IonCollection example #207

Closed wtbarnes closed 1 year ago

wtbarnes commented 1 year ago

Fixes #172 Fixes #205 Fixes #204

Also includes a few other miscellaneous fixes.

codecov-commenter commented 1 year ago

Codecov Report

Base: 90.13% // Head: 89.66% // Decreases project coverage by -0.46% :warning:

Coverage data is based on head (a6bf8fd) compared to base (99e760b). Patch coverage: 43.75% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #207 +/- ## ========================================== - Coverage 90.13% 89.66% -0.47% ========================================== Files 23 23 Lines 1865 1878 +13 ========================================== + Hits 1681 1684 +3 - Misses 184 194 +10 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/ions.py](https://codecov.io/gh/wtbarnes/fiasco/pull/207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvbnMucHk=) | `92.92% <ø> (ø)` | | | [fiasco/util/setup\_db.py](https://codecov.io/gh/wtbarnes/fiasco/pull/207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvc2V0dXBfZGIucHk=) | `61.53% <30.00%> (-5.94%)` | :arrow_down: | | [fiasco/collections.py](https://codecov.io/gh/wtbarnes/fiasco/pull/207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2NvbGxlY3Rpb25zLnB5) | `90.00% <60.00%> (-1.21%)` | :arrow_down: | | [fiasco/elements.py](https://codecov.io/gh/wtbarnes/fiasco/pull/207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2VsZW1lbnRzLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wtbarnes commented 1 year ago

Adding this as a note for myself. To reproduce the publish build failures locally,

conda create -n fiasco-build-dev python=3.10 -y
python -m pip install pip build twine --upgrade
python -m build --sdist .
python -m venv test-sdist
source test-sdist/bin/activate
which python
python -m pip install --force-reinstall "`find dist -name "*.tar.gz"`[dev]"
cd $TMPDIR
python -m pytest -p no:warnings --doctest-rst --pyargs fiasco