wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Fix version checking #210

Closed wtbarnes closed 1 year ago

wtbarnes commented 1 year ago

Fixes #209

There is a bug in checking the compatible CHIANTI versions. This fixes it by checking for the version in the right place.

This also includes a few fixes that make the building of the HDF5 file much more quiet by default.

codecov-commenter commented 1 year ago

Codecov Report

Base: 90.52% // Head: 90.91% // Increases project coverage by +0.39% :tada:

Coverage data is based on head (5c45a4b) compared to base (bda42b1). Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #210 +/- ## ========================================== + Coverage 90.52% 90.91% +0.39% ========================================== Files 23 23 Lines 1878 1882 +4 ========================================== + Hits 1700 1711 +11 + Misses 178 171 -7 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/io/factory.py](https://codecov.io/gh/wtbarnes/fiasco/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvL2ZhY3RvcnkucHk=) | `75.86% <0.00%> (ø)` | | | [fiasco/ions.py](https://codecov.io/gh/wtbarnes/fiasco/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvbnMucHk=) | `92.92% <ø> (ø)` | | | [fiasco/io/generic.py](https://codecov.io/gh/wtbarnes/fiasco/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvL2dlbmVyaWMucHk=) | `92.85% <100.00%> (+0.26%)` | :arrow_up: | | [fiasco/util/setup\_db.py](https://codecov.io/gh/wtbarnes/fiasco/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvc2V0dXBfZGIucHk=) | `80.21% <100.00%> (+3.29%)` | :arrow_up: | | [fiasco/io/datalayer.py](https://codecov.io/gh/wtbarnes/fiasco/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvL2RhdGFsYXllci5weQ==) | `74.71% <0.00%> (+4.59%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.